Automated Resyntax fixes#814
Closed
resyntax-ci[bot] wants to merge 10 commits into
Closed
Conversation
These list element variable definitions can be expressed more succinctly with `match-define`. Note that the suggested replacement raises an error if the list contains more elements than expected.
Using `cond` allows converting `let` to internal definitions, reducing nesting
This use of `printf` has no arguments other than the template string.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This expression can be replaced with a simpler, equivalent `hash-update!` expression.
Use the `#:when` keyword instead of `when` to reduce loop body indentation.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
Nested `when` expressions can be merged into a single compound `when` expression.
This use of `define-values` is unnecessary.
These nested `for` loops can be replaced by a single `for*` loop.
rfindler
reviewed
Jul 19, 2026
| (define id/name (place-channel-get local-chan)) | ||
| (define id (list-ref id/name 0)) | ||
| (define name (list-ref id/name 1)) | ||
| (match-define (list id name) id/name) |
Member
There was a problem hiding this comment.
How does the refactoring know the list has only two elements?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 20 issues in 3 files.
let-to-definenested-when-to-compound-whenlist-element-definitions-to-match-definewhen-expression-in-for-loop-to-when-keywordprintf-to-displayand-let-to-condnested-for-to-for*define-values-values-to-definehash-set!-ref-to-hash-update!cond-let-to-cond-define